Hi Chris,
Thanks for writing the tests overall code looks good to me, below are
few minor comments.
1`-> Fix tag order, my Netbeans always complains :) .
2-> you make AuthRecursiveBase class as public but i can not see it is
being used outside, i will suggest you to give the default access if
possible.
3-> AuthTrue.java, change the message as follows
"Got exception as expected : " -> "Got expected exception: ";
4-> PortUnreachable.java , any specific reason for 1000ms or you just
choose random value ? Please don't hard-code this specific value create
a constant and use it . If possible put some comment why we choose 1
second, this will help in debugging if this test fails intermittently in
future.
5-> Timeout.java, do you really need to set the env using
"DNSTestUtils.initEnv" ?
I see, this test is not using the DNSServer and other environments
variables which were set by "DNSTestUtils.initEnv()" or i am missing
something.
Thanks,
Vyom
On Wednesday 25 July 2018 02:41 PM, Chris Yin wrote:
Please review the changes to add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/
in OpenJDK, due to known issue 7164518, PortUnreachable.java will be problem
list for 'macosx-all', thanks
bug: https://bugs.openjdk.java.net/browse/JDK-8200151
<https://bugs.openjdk.java.net/browse/JDK-8200151>
webrev: http://cr.openjdk.java.net/~xyin/8200151/webrev.00/
<http://cr.openjdk.java.net/~xyin/8200151/webrev.00/>
Regards,
Chris
