Hi Chris,

The refactored  java class (RunBasic.java) looks good to me.

Thanks,

Vyom


On Tuesday 28 August 2018 11:20 AM, Chris Yin wrote:
Please have a review for below change to refactor shell test 
javax/naming/module/basic.sh to plain java, no test logic change, old shell 
script is removed at same time, thanks

bug: https://bugs.openjdk.java.net/browse/JDK-8209773
webrev: http://cr.openjdk.java.net/~xyin/8209773/webrev.00/

Regards,
Chris

Reply via email to