Thank you, Alan Sure, I modified a little to remove “.” and use Path.of as you suggested to improve file handling, minor revision as below, thanks
http://cr.openjdk.java.net/~xyin/8209773/webrev.01/ Regards, Chris > On 10 Sep 2018, at 3:20 PM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 30/08/2018 10:06, vyom tewari wrote: >> Hi Chris, >> >> The refactored java class (RunBasic.java) looks good to me. > Looks okay to me too but the file handling could be improved, e.g. no need to > resolve path against ".", should specify the elements to Path.of so that they > use the right separator for the platform. > > -Alan
