On 26/09/2018 19:16, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8211171/webrev.00/index.html
Looks good but maybe it should be put into a named package (see below).

:
please note, there is another version of JarUtils in jdk.test.lib.util package, 
but these two versions have different signatures and behavior, merging them is 
a bit tricker and will be done separately.

The JarUtils that are moving today to test/lib is one that I added as test infrastructure some time ago. I don't where test/lib/jdk/test/lib/util/JarUtils.jav came from but it seems less useful. It makes me wonder if it would be better to just convert tests rather than merging. A few convenience methods added to the JarUtils you are moving would make that easier.

-Alan

Reply via email to