Hi Igor,
The IDEs including IntelliJ can pretty easily search for usages of
various methods
whereever they occur in the source tree. And they can do the refactoring
as well.
$.02, Roger
On 10/11/2018 02:55 PM, Igor Ignatyev wrote:
Hi Max,
we do have a plan to remove these deprecated methods as part of 8211289[1].
I don't know if there a flag which you can use to get all classes which use
deprecated methods. you can however analyze source or bytecode of tests, to see
if they have dependency on these methods, but again I ain't aware of tools
(rather than grep) which can help you to do that in jtreg test suite.
[1] https://bugs.openjdk.java.net/browse/JDK-8211289
<https://bugs.openjdk.java.net/browse/JDK-8211289>
-- Igor
On Oct 10, 2018, at 8:47 PM, Weijun Wang <weijun.w...@oracle.com> wrote:
Do we have a plan to move away from the deprecated methods? Is there a flag I
can set to check how many classes are using them?
--Max
On Sep 30, 2018, at 11:00 PM, Alan Bateman <alan.bate...@oracle.com> wrote:
On 27/09/2018 00:38, Igor Ignatyev wrote:
here is the webrevs w/ JarUtils from default package inserted into
jdk.test.lib.util.JarUtils:
whole patch: http://cr.openjdk.java.net/~iignatyev//8211171/webrev.01/index.html
<http://cr.openjdk.java.net/%7Eiignatyev//8211171/webrev.01/index.html>
655 lines changed: 239 ins; 355 del; 61 mod;
incremental: http://cr.openjdk.java.net/~iignatyev//8211171/webrev.0-1/index.html
<http://cr.openjdk.java.net/%7Eiignatyev//8211171/webrev.0-1/index.html>
476 lines changed: 239 ins; 203 del; 34 mod;
doing that, I noticed that both updateJarFile and createJarFile don't close
Stream<Path> from Files::find, the current patch fixes that.
I see you've also deprecated the String methods in the old class - good! I'd
probably carry over test/jdk/lib/testlibrary/JarUtils.java without changing the
format but your IDE must be setup differently and it will get changed again by
whoever next changes it so I think it's okay.
The update to tests using this look fine.
-Alan
--
Thanks, Roger
