Hi Roger, The changes look reasonable to me.
Happy New Year > On Jan 3, 2019, at 3:47 PM, Roger Riggs <[email protected]> wrote: > > Please review a bug fix for the ProcessBuilder startPipeline test and Windows > implementation. > The test failed to check that Process.getInputStream returned the null stream > for all but the last process in the pipeline. When the test was fixed it > failed on Windows. > The Windows ProcessImpl did not ensure that getInputStream returned a null > stream. > > The same issue was found and fixed in the AIX implementation (JDK-8211844) > which prompted investigation of the test. > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-pipeline-8211844/ > > Happy New Year! Roger > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 [email protected] <mailto:[email protected]>
