Roger, Looks OK.
One small point, I know it is only a test but do you need the extra System.out.printf statements, they look as though they might have been just for debugging. No issues if they stay in there just wondering if it was a oversight in removing them. Also, need to have the copyright dates changed as we are now in 2019. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groe...@uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: Roger Riggs <roger.ri...@oracle.com> To: core-libs-dev <core-libs-dev@openjdk.java.net> Date: 03/01/2019 20:48 Subject: 8216134 (process) ProcessBuilder startPipeline does not hide piped streams Sent by: "core-libs-dev" <core-libs-dev-boun...@openjdk.java.net> Please review a bug fix for the ProcessBuilder startPipeline test and Windows implementation. The test failed to check that Process.getInputStream returned the null stream for all but the last process in the pipeline. When the test was fixed it failed on Windows. The Windows ProcessImpl did not ensure that getInputStream returned a null stream. The same issue was found and fixed in the AIX implementation (JDK-8211844) which prompted investigation of the test. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-pipeline-8211844/ Happy New Year! Roger Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
