Hi Steve, feel free to request the downport of this change.
For this, you must first check whether the change applies cleanly: cd jdk/jdk; hg export -r 7384e00d5860 > 8215962.changeset (you find the hash in the JBS) cd jdk11u; hg import 8215962.changeset If so, you flag the bug in JBS as jdk11u-fix-request and add a comment to the bug why you want to downport this. The comment must start with "Fix Request". See for an example https://bugs.openjdk.java.net/browse/JDK-8215962 You will get a message once the downport is approved. Ping me and I will push the change for you. If the change does not apply cleanly, you must send a RFR with the adapted webrev to the list where the change was originally reviewed. You must add a link to the RFR in pipermail to the comment in the bug. See for example: https://bugs.openjdk.java.net/browse/JDK-8213754 Best regards, Goetz. > -----Original Message----- > From: core-libs-dev <core-libs-dev-boun...@openjdk.java.net> On Behalf Of > Steve Groeger > Sent: Mittwoch, 23. Januar 2019 12:18 > To: OpenJDK Core Libs Developers <core-libs-dev@openjdk.java.net> > Cc: Simonis, Volker <volker.simo...@sap.com>; Adam Farley8 > <adam.far...@uk.ibm.com> > Subject: JDK-8214063: OpenJDK will not build on AIX while using the xlc 13.1 > compiler > > Hi Volker, > > Do you think it would be possible to get the change you committed to JDK12 > http://cr.openjdk.java.net/~simonis/webrevs/2018/8214063/ > for this issue https://bugs.openjdk.java.net/browse/JDK-8214063 > back-ported to JDK11, as JDK11 is a LTS release and it woud be good to > have this fix? > > Also, we have received reports of other issues caused by the > -qvisibility=hidden > when using XLC 13.1 with JDK11 on AIX. > > One of these is related to : > > Desktop printer feature cannot detect by following exception. > Caused by: java.lang.UnsatisfiedLinkError: > sun/print/CUPSPrinter.initIDs()Z > > Thanks > Steve Groeger > IBM Runtime Technologies > Hursley, Winchester > Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 > Fax (44) 1962 816800 > Lotus Notes: Steve Groeger/UK/IBM > Internet: groe...@uk.ibm.com > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU > > > > Hi Adam, Ichiroh, > > > > this is actually exactly what I wanted to propose in the mail I was > > just writing :) > > > > You may have noticed that I've renamed the bug to "8214063: [AIX] > > Disable symbol visibility flags". For the next step which will enable > > symbol visibility on AIX we already have the following issue "8204541: > > Correctly support AIX xlC 13.1 symbol visibility flags" [1]. Please > > assign yourself and use it once the issues are resolved. > > > > In the meantime I've tested your change and it works fine with xlC 12. > > I've only added a reference to the JBS id in the comments. Please find > > a webrev of the new version here: > > > > http://cr.openjdk.java.net/~simonis/webrevs/2018/8214063/ > > > > I can sponsor that change once you and Ichiroh confirm that it also > > works for you with xlC 13 and I get one more review. I've opened a new > > thread for this on build-dev because the fix has now degenerated into > > a pure build change: > > > > > http://mail.openjdk.java.net/pipermail/build-dev/2018- > November/024096.html > > > > Please answer on that new thread. > > > > Regards, > > Volker > > > > PS: I don't think it makes too much sense investing into xlC 13. > > You're probably aware of "JEP 347: Adopt C++14 Language Features in > > HotSpot" [2] which will start introducing C++14 language features > > soon. So it may be wiser to test right with the new beta of xlC 16 > > because, as far as I know, there's no chance to get C++124 support > > into xlC 13 anyway. > > > > [1] https://bugs.openjdk.java.net/browse/JDK-8204541 > > [2] http://openjdk.java.net/jeps/347 > > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU