> On Feb 21, 2019, at 12:19 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > On 21/02/2019 05:19, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8219139/webrev.00/index.html >>> 40 lines changed: 17 ins; 2 del; 21 mod; >> Hi all, >> >> could you please review this small patch which moves tests from test/jdk/vm? >> >> there are 16 tests in test/jdk/vm directory. all but JniInvocationTest are >> hotspot tests, so they are moved to test/hotspot test suite; >> JniInvocationTest is a launcher test and hence it's moved to >> test/jdk/tools/launcher. as hotspot/compiler and hotspot/gc tests use >> packages, the tests moved there have been updated to have a package >> statement. >> >> webrev: http://cr.openjdk.java.net/~iignatyev//8219139/webrev.00/index.html >> JBS: https://bugs.openjdk.java.net/browse/JDK-8219139 >> testing: tier[1-2] (in progress), all the touched tests locally >> > The tools/launcher directory is the tests for the java launcher, I don't > think it's the right place for tests for the JNI invocation interface - I > think that one is asking to be moved to be with the other JNI tests. Alan, you are right, this test is a JNI test and should be moved to hotspot/runtime/jni. more details in my answer to the same comment in David's email. in two words, I accidentally looked at another test.
-- Igor > > -Alan
