Hi Thomas, Will do and appreciate the support!
Cheers, Martijn On Wed, 27 Mar 2019 at 11:13, Thomas Stüfe <thomas.stu...@gmail.com> wrote: > > > On Wed, Mar 27, 2019 at 11:08 AM Martijn Verburg <martijnverb...@gmail.com> > wrote: > >> Hi Thomas, >> >> Release only (we've only created debug builds for x64), >> > > Okay. A number of those errors were debug only. > > >> we do use the treat errors as warnings flag. >> > > Other way around, I hope ;) > > >> >> You can look at all of our build configurations and build histories at >> ci.adoptopenjdk.net - and I've copied in Ali Ince who's working for >> jClarity on Windows 32/64 builds amongst other things. >> >> Okay, that's useful. > > JDK changes have been pushed (JDK-8221405 > <https://bugs.openjdk.java.net/browse/JDK-8221405> , JDK-8221406 > <https://bugs.openjdk.java.net/browse/JDK-8221406> , JDK-8221407 > <https://bugs.openjdk.java.net/browse/JDK-8221407> , first one in > jdk/client since awt maintainers asked me to). Hotspot changes still under > review, we ponder the best way to deal with a supposed vc++ bug here ( > JDK-8221408 <https://bugs.openjdk.java.net/browse/JDK-8221408> ). Feel > free to test or review. > > Note that I do not plan to keep windows 32 bit alive, this was just a > weekend thing because I needed a 32bit VM on windows for some comparisons. > So I'd be happy that you guys are regularly building it (if possible > fastdebug too). Please report any build breaks. When reported promptly, > with the offending change linked in JBS, the authors will often try to fix > it themselves. > > Cheers, Thomas > > >> Cheers, >> Martijn >> >> >> On Tue, 26 Mar 2019 at 06:04, Thomas Stüfe <thomas.stu...@gmail.com> >> wrote: >> >>> >>> >>> On Mon, Mar 25, 2019 at 10:49 PM Martijn Verburg < >>> martijnverb...@gmail.com> wrote: >>> >>>> Hi all, >>>> >>>> Snipping much, but commenting on one statement inline below. >>>> >>>> On Mon, 25 Mar 2019 at 01:58, David Holmes <david.hol...@oracle.com> >>>> wrote: >>>> >>>>> Hi Thomas, >>>>> >>>>> A few queries, comments and concerns ... >>>>> >>>>> On 25/03/2019 6:58 am, Thomas Stüfe wrote: >>>>> > Hi all, >>>>> > >>>>> > After a long time I tried to build a Windows 32bit VM (VS2017) and >>>>> failed; >>>>> >>>>> I'm somewhat surprised as I thought someone was actively doing Windows >>>>> 32-bit builds out there, plus there are shared code changes that >>>>> should >>>>> also have been caught by non-Windows 32-bit builds. :( >>>>> >>>> >>>> AdoptOpenJDK is building Win-32 but we only recently swapped to VS2017 >>>> to do so and have hit the same issues (Thomas beat us to reporting!). >>>> >>>> >>> Still curious what you actually build, since I believe not all of the >>> issues are related to vs2017. >>> >>> Do you build release only or also debug? Do you build with >>> warnings-as-errors disabled? >>> >>> >>>> Hopefully, we'll have that nightly warning system in place for you >>>> going forward soon. >>>> >>>> >>> That would be helpful. >>> >>> Cheers, Thomas >>> >>> >>>> Cheers, >>>> Martijn >>>> >>>
