On 06/04/2019 19:05, Alan Bateman wrote: > On 05/04/2019 11:50, Andrew Dinn wrote: >> : >> Ah ok, got it now. I think I was confused by a missing 'not' in your >> original response. >> >> I have now removed the @throws for NPE from the MapMode constructor >> javadoc as well as letting the call to length() perform the null check. >> >> new webrev: http://cr.openjdk.java.net/~adinn/8221397/webrev.00/ >> JIRA: https://bugs.openjdk.java.net/browse/JDK-8221397 >> > This versions look, I assume you'll create the CSR and wait for it to be > approved before pushing. I created the following CSR
https://bugs.openjdk.java.net/browse/JDK-8222107 Apologies if I got anything wrong (first time I have done this :-). Do I need to solicit reviews or does this automatically get dispatched to the relevant component/sub-component leads? regards, Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
