On 09/04/2019 17:02, Andrew Dinn wrote:
In response to Alan's suggestion (included below) I have reverted the
constructor for MapMode to private and will use behind the scenes access
to construct the extended enum values.
This change removes the need to modify the test in MapTest.java (no new
API to exercise).
It still requires javadoc changes in FileChannel.map and implementation
changes in FileChannelImpl.java. Reveiews for the udpated webrev would
be welcome. I'll post a separate request for review of the CSR changes.
JIRA: https://bugs.openjdk.java.net/browse/JDK-8221397
new webrev: http://cr.openjdk.java.net/~adinn/8221397/webrev.03
I think this looks fine. I've added myself as Reviewer to the CSR too.
-Alan
