Hi Daniel, Thanks for agreeing to sponsor this update. Have created a new webrev [1] according to the instructions you pointed me at. Would be grateful if you could re-review and then do whatever is needed to get this into the code.
[1] http://cr.openjdk.java.net/~sgroeger/8222027/webrev.03/ Once this is contributed to jdk repository, could this also be contributed back to jdk11u. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: [email protected] Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: Daniel Fuchs <[email protected]> To: Steve Groeger <[email protected]> Cc: OpenJDK Core Libs Developers <[email protected]> Date: 05/04/2019 14:33 Subject: Re: RFR: TEST_BUG: 8222027 - java/util/logging/LogManager/TestLoggerNames.java generates intermittent ClassCastException On 05/04/2019 14:01, Steve Groeger wrote: > Hi Daniel, > > Thanks. I should have spotted that slight mistake. That is what comes > from just cutting and pasting. > Have created a new webrev anyway: > _https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Esgroeger_8222027_webrev.02_-5F&d=DwIC-g&c=jf_iaSHvJObTbx-siA1ZOg&r=78GW2OHz7nNTH2dBkTx7-TKh2QCt3JD3zukzeUO8RpA&m=qRBq_TynpHvQNvdfqbB7xtbvHge-g3BD_lQQ56j9110&s=xjkl3b-FfGR3bIdqBiOjwMHlW9cHN8xVX0fCH-m7T3M&e= > I presume I need someone else to review this and also get a sponsor (so > they can actually make the change) as I am not a committer (YET!!!) > Do you know anyone that can do this for me? If you don't have a sponsor at IBM I can sponsor it for you. You will need to make a proper changeset that can be hg imported. (simplest way is to hg commit the change in your local workspace with the proper commit comment [1] and call webrev again, then do hg rollback immediately after). BTW since this is a a test bug then the @bug tag doesn't need to be updated. Instead you should add a noreg-self label to the JBS issue, if it's not already there. [1] https://urldefense.proofpoint.com/v2/url?u=http-3A__openjdk.java.net_guide_producingChangeset.html&d=DwIC-g&c=jf_iaSHvJObTbx-siA1ZOg&r=78GW2OHz7nNTH2dBkTx7-TKh2QCt3JD3zukzeUO8RpA&m=qRBq_TynpHvQNvdfqbB7xtbvHge-g3BD_lQQ56j9110&s=eQWzg0PXYNpTeqADJ8MBzKvMhlQ5fbacEcmWkB7a5cc&e= best regards, -- daniel Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
