Hi Daniel, Thanks, have created a new webrev [1] Once it is merged I will then work on getting it back-ported to jdk11u. Thanks for all your assistance in getting this done.
[1] http://cr.openjdk.java.net/~sgroeger/8222027/webrev.04/ Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groe...@uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: Daniel Fuchs <daniel.fu...@oracle.com> To: Steve Groeger <groe...@uk.ibm.com> Cc: OpenJDK Core Libs Developers <core-libs-dev@openjdk.java.net> Date: 08/04/2019 12:53 Subject: Re: RFR: TEST_BUG: 8222027 - java/util/logging/LogManager/TestLoggerNames.java generates intermittent ClassCastException Hi Steve, On 08/04/2019 12:21, Steve Groeger wrote: > Hi Daniel, > > Thanks for agreeing to sponsor this update. > Have created a new webrev [1] according to the instructions you pointed > me at. > Would be grateful if you could re-review and then do whatever is needed > to get this into the code. > > [1] _https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Esgroeger_8222027_webrev.03_-5F&d=DwID-g&c=jf_iaSHvJObTbx-siA1ZOg&r=78GW2OHz7nNTH2dBkTx7-TKh2QCt3JD3zukzeUO8RpA&m=41IZgAR3sbHm4Hguv8daLthkNQet2Z01z67syH-9YRQ&s=lly5Dkb_dCxGkoo7yv2lrqeeUTngOBJOPgC1zpq-Vz8&e= If you look at https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Esgroeger_8222027_webrev.03_jdk.changeset&d=DwID-g&c=jf_iaSHvJObTbx-siA1ZOg&r=78GW2OHz7nNTH2dBkTx7-TKh2QCt3JD3zukzeUO8RpA&m=41IZgAR3sbHm4Hguv8daLthkNQet2Z01z67syH-9YRQ&s=QZGivAQl3ESAhnQfkj2g98WbRTcHhZ9xHvsBVZa6K1g&e= you will see that your OpenJDK user name already appears in the changeset (line 2) - so you don't need the Contributed-by line. The changeset, when pushed, will already appear has being authored by `sgroeger`. The contributor line is only needed when the contributor is not an OpenJDK author yet, or when there are several contributors. Could you please remove that line and regenerate the changeset? I'll then be able to import it in my local repo - verifies that our test system is happy with it (I don't expect any issue there), and push it for you. > Once this is contributed to jdk repository, could this also be > contributed back to jdk11u. You will need to negotiate that with the OpenJDK 12 and OpenJDK 11 maintainers - and follow the rules for the updates projects there: https://urldefense.proofpoint.com/v2/url?u=http-3A__openjdk.java.net_projects_jdk-2Dupdates_&d=DwID-g&c=jf_iaSHvJObTbx-siA1ZOg&r=78GW2OHz7nNTH2dBkTx7-TKh2QCt3JD3zukzeUO8RpA&m=41IZgAR3sbHm4Hguv8daLthkNQet2Z01z67syH-9YRQ&s=G2UKtWyGya28sjIe7qXTC0MnM7GO4Jw9AxQP-X86vNk&e= Since this is a test bug that should apply cleanly I don't think that should be an issue. But you will need to find a sponsor for those. best regards, -- daniel > > Thanks > Steve Groeger > IBM Runtime Technologies > Hursley, Winchester > Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 > Fax (44) 1962 816800 > Lotus Notes: Steve Groeger/UK/IBM > Internet: groe...@uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
