Hi Vladimir,
On 20/06/2019 02:03, Vladimir Kozlov wrote:
http://cr.openjdk.java.net/~kvn/8185139/webrev.00/
Ah - I see that the logging test are the principal offenders here.
Sorry about that ;-(
I looked at the various logging tests and the proposed changes look
good to me. Thanks for updating them!
I skimmed through the rest and didn't see any particular issue.
best regards,
-- daniel
https://bugs.openjdk.java.net/browse/JDK-8185139
For Graal to work we have to give Graal module all permissions which is
specified in default policy [1].
Unfortunately this cause problem for Graal running tests which overwrite
default policy.
I discussed this with Mandy and she suggested that such tests should
also check default policy. I implemented her suggestion. Note, this is
not only Graal problem. There were already similar fixes before [2].
I also updated Graal's problem list. Several tests were left on problem
list (with different bug id) because they would not run with Java Graal
(for example, they use --limit-modules flag which prevents loading Graal
module). We will enable such tests again when libgraal is supported.
I ran testing which execute these tests with Graal. It shows only known
problems which are not related to these changes.
Thanks,
Vladimir
[1]
http://hg.openjdk.java.net/jdk/jdk/file/49ed5e31fe1e/src/java.base/share/lib/security/default.policy#l156
[2] https://bugs.openjdk.java.net/browse/JDK-8189291