I agree with Daniel.
I did look into factoring SimplePolicy into a separate file but found, as Daniel pointed, there were some differences
which would complicate this common class and would require more time to make such changes.
Thank you Daniel, Roger and Alan for reviews. And special thanks to Mandy for helping me with this issue from start to
finish.
Thanks,
Vladimir
On 6/20/19 9:40 AM, Daniel Fuchs wrote:
Hi Alan,
On 20/06/2019 16:36, Alan Bateman wrote:
I think that's right. In the case of the j.u.logging tests then maybe SimplePolicy could be factored out into a
separate source file so there aren't 20 or so tests with a SimplePolicy and implies method that checks the default
policy.
I don't like this idea much as there can be some subtle differences
between these SimplePolicy classes. I strongly hope that having
to modify these test policy implementations is not something that we
will need to do very often, and trying to factor out the SimplePolicy
implementation is likely to be more trouble than it's worth.
best regards,
-- daniel
-Alan
