Hi Brian, Are we having fun yet ;-)
The back out looks good > On Jul 18, 2019, at 4:01 PM, Brian Burkhalter <[email protected]> > wrote: > > >> On Jul 18, 2019, at 12:35 PM, Brian Burkhalter <[email protected]> >> wrote: >> >>> On Jul 18, 2019, at 12:34 PM, Lance Andersen <[email protected] >>> <mailto:[email protected]>> wrote: >>> >>>> One thing which should be considered as an alternative would be not to >>>> check for null at all in these constructors but update the subclass >>>> constructor specifications to override the class documentation and >>>> indicate that the underlying stream parameter may be null. >>> >>> I think this might be the better way to go.. >> >> Agreed. I therefore withdraw this patch and will use this issue for the back >> out. > > A patch which backs out the java.io.Filter{In,Out}put stream constructors > null underlying stream check (and consequent changes) is at [1]. > > A tier 1-3 test run is in progress. > > Thanks, > > Brian > > [1] http://cr.openjdk.java.net/~bpb/8228392/webrev.01/ <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 [email protected] <mailto:[email protected]>
