Hi, Leo. Thanks for adding legal notices (copyright and license) to these resource .property files.
For the files in src/demo/share/jfc/*.properties, is there any reason why the legal notices should not be in a separate comment block? Right now, it appears that you've prepended the legal notices to any existing comment block at the beginning of the file. I recommend that the first comment block contain only the legal notices, as is the convention for .java and other files. Thanks, iris -----Original Message----- From: Leo Jiang Sent: Monday, July 22, 2019 9:23 AM To: jdk-dev <jdk-...@openjdk.java.net>; core-libs-dev <core-libs-dev@openjdk.java.net> Subject: RFR: 8228397: Missing license copyright header in some resource properties files Hi all, Please review this change. We found the license copyright header are missing in some resource properties files, some of them are very old and no hg log since code forest consolidation. In this change, I added the license copyright header in the English and its localized resource files. Bug: https://bugs.openjdk.java.net/browse/JDK-8228397 Webrev: http://cr.openjdk.java.net/~ljiang/8228397/webrev.00/ Thanks, Leo
