Hi, Leo., This updated webrev looks fine.
Thanks for fixing! iris -----Original Message----- From: Leo Jiang Sent: Tuesday, July 23, 2019 12:08 AM To: Mandy Chung <mandy.ch...@oracle.com> Cc: jdk-dev <jdk-...@openjdk.java.net>; core-libs-dev <core-libs-dev@openjdk.java.net> Subject: Re: RFR: 8228397: Missing license copyright header in some resource properties files Thank you for your reviewing. Updated the webrev: http://cr.openjdk.java.net/~ljiang/8228397/webrev.01/ I know the update is trivial, if no more suggestion I will push the patch tomorrow. Thanks, Leo On 7/23/19 3:55 AM, Mandy Chung wrote: > Hi Leo, > > Thanks for adding the copyright and license header. The patch looks > okay assuming you will separate the legal notices from the existing > comment block in JFC properties files. > > Mandy > > On 7/22/19 9:23 AM, li.ji...@oracle.com wrote: >> Hi all, >> >> Please review this change. >> >> We found the license copyright header are missing in some resource >> properties files, some of them are very old and no hg log since code >> forest consolidation. In this change, I added the license copyright >> header in the English and its localized resource files. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8228397 >> Webrev: http://cr.openjdk.java.net/~ljiang/8228397/webrev.00/ >> >> Thanks, >> Leo >> >
