Looks good with one question:
In Arguments.java:
+ if (bundler.isDefault()) {
+ return bundler;
+ } else {
+ savedBundler = bundler;
+ }
When would there be a valid case where you loop through the list of
bundlers and don't find a default? It may be better to throw an error in
that case rather than just return the last one found.
-- Kevin
On 9/8/2019 2:50 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This fix:
Adds "app-image" as a valid value for "--package-type" options,
meaning build an application image instead of a package.
Changes the default value of "--package-type" to a platform dependent
default package type.
[1] https://bugs.openjdk.java.net/browse/JDK-8230519
[2] http://cr.openjdk.java.net/~herrick/8230519/webrev.01/
Thanks
Andy,
