Hi Andy,

http://cr.openjdk.java.net/~herrick/8230519/webrev.02/test/jdk/tools/jpackage/share/ErrorTest.java.frames.html
Line 90: Add space before ARG2.

Looks good.

Thanks,
Alexander

On 9/9/2019 3:25 PM, Andy Herrick wrote:
Please review the updated jpackage fix for bug [1] at [3].

Functional change:  If the default package type is called for, but for some reason the default package type is not supported on this machine, it will be an error (we will not try to build any other package type)

Typo fixed in comment, and small fix to RuntimeTest.java.

[3] http://cr.openjdk.java.net/~herrick/8230519/webrev.02/

/Andy

On 9/8/2019 5:50 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].

This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage).

This fix:

Adds "app-image" as a valid value for "--package-type" options, meaning build an application image instead of a package.

Changes the default value of "--package-type" to a platform dependent default package type.

[1] https://bugs.openjdk.java.net/browse/JDK-8230519
[2] http://cr.openjdk.java.net/~herrick/8230519/webrev.01/

Thanks

Andy,


Reply via email to