I'm happy with the overall changeset. I have (once again) made some tiny 
changes, you can see them here:


If you are okay with them, then we wait for a *R*eviewer. If the Reviewer(s) 
are okay with them, we push. For the record, I'm not really happy with how we 
used the DNSTestBase/TestBase infrastructure, however I'm totally fine with the 
retrying logic.

Test results are pending.


> On 10 Sep 2019, at 16:33, Milan Mimica <milan.mim...@gmail.com> wrote:
>>> On 5 Sep 2019, at 16:02, Pavel Rappo <pavel.ra...@oracle.com> wrote:
>>> I think we are almost there. What do you think of the following incremental 
>>> (i.e. on top of your latest webrev) change?
>>>   http://cr.openjdk.java.net/~prappo/8228580/webrev.01/
>>> I fixed a couple of trivial typos and addressed the socket relinquishing 
>>> issue. Initializing a socket is not an atomic "all-or-nothing" operation 
>>> now. Someone needs to take care of the socket in case things go not as 
>>> planned.
> Right. Thanks. Here is the merged version:
> http://cr.openjdk.java.net/~mmimica/8228580/webrev.02/
> Plus, I have added TCP server init retry code from Chris. Works fine
> without changes to TestBase.
> -- 
> Milan Mimica

Reply via email to