+SeanC

The wait might unnecessarily increase the test time. Maybe you can do something 
like this:

   int timeout = 10;
   while (timeout > 0) {
      sleep(one second);
      verifyPortFree && return;
      timeout--;
   }
   throw new Exception(still not freed);

And Sean, back in JDK-8016728 you said "Let's extend it to 1000ms and see how 
test behaves". So what do you think?

Thanks,
Max

> On Oct 15, 2019, at 10:03 AM, Hamlin Li <[email protected]> wrote:
> 
> Hi,
> 
> The test is failing more frequently, could some help to review it?
> 
> Thank you
> 
> -Hamlin
> 
> On 2019/9/4 11:11 AM, Hamlin Li wrote:
>> some background & comment: in most of failures, the "test.timeout.factor" is 
>> 10.0 or 8.0, so in the test code this factor should be considered in rmi 
>> operations such unexporting an object.
>> 
>> Thank you
>> 
>> -Hamlin
>> 
>> On 2019/9/4 11:01 AM, Hamlin Li wrote:
>>> Hi,
>>> 
>>> Would you please review the following patch?
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8134599
>>> 
>>> webrev: http://cr.openjdk.java.net/~mli/8134599/webrev.00/
>>> 
>>> 
>>> Thank you
>>> 
>>> -Hamlin
>>> 

Reply via email to