> On Oct 16, 2019, at 9:37 AM, Hamlin Li <[email protected]> wrote:
>
>
> On 2019/10/16 9:26 AM, Weijun Wang wrote:
>
>>>>>> Even after this bug is resolved, I'd suggest add some logging and rerun
>>>>>> this test unchanged multiple times to see what really happened.
>>>>> Unfortunately, most of time this kind of issue is not easy to reproduce
>>>>> by running it multiple times. In my point of view, current logging is
>>>>> sufficient for diagnosing.
>>>> I see some logging calls inside source code. Maybe you can set a logging
>>>> config file to let it show more?
>>> I'm not sure I get your point, could you help to clarify?
>> For example, in
>> src/java.rmi/share/classes/sun/rmi/transport/ObjectTable.java, there is
>>
>> if (DGCImpl.dgcLog.isLoggable(Log.VERBOSE)) {
>> DGCImpl.dgcLog.log(Log.VERBOSE, "remove object " + oe);
>> }
>>
>> So it looks it supports logging. Maybe you can provide a logging config file
>> with -Djava.util.logging.config.file and see more info.
>
> Good point, I think we can do further: add logging for not just this tests,
> but for other frequently failed rmi tests.
>
> But as this is failing so frequently we need a quick fix or have to
> problemlist it first, so I just created a bug to track this enhancement:
> https://bugs.openjdk.java.net/browse/JDK-8232352, how do you think about it?
Not problem.
Thanks,
Max
>
> Thank you
>
> -Hamlin
>
>>
>> Thanks,
>> Max
>>
>>> Thank you
>>>
>>> -Hamlin
>>>
>>>> --Max
>>>>
>>>>> Thank you
>>>>>
>>>>> -Hamlin
>>>>>
>>>>>> --Max
>>>>>>
>>>>>>
>>>>>>> On Oct 15, 2019, at 11:04 AM, Hamlin Li <[email protected]> wrote:
>>>>>>>
>>>>>>> Thanks for reviewing, I updated change at:
>>>>>>> http://cr.openjdk.java.net/~mli/8134599/webrev.01/
>>>>>>>
>>>>>>> it does not increase minimum time time and consider timeout factor at
>>>>>>> the same time.
>>>>>>>
>>>>>>> Thank you
>>>>>>>
>>>>>>> -Hamlin
