On 16/10/2019 6:28 pm, Schmelter, Ralf wrote:
Hi David,
the canonicalize() method is never used by java.io or any Java code. Currently
it is used by the hotspot in classloader.cpp (which I use in the test) and in
libinstrument in InvocationAdapter.c. There is no way to test it in core-libs.
One can argue if the canonicalize method is in the right file, but that should
be a separate discussion.
Sorry Ralf, yes you are correct. What a strange arrangement.
The test change seems fine in that case.
I'm afraid I can't comment on the actual fix, sorry.
Thanks,
David
-----
Best regards,
Ralf
-----Original Message-----
From: David Holmes <[email protected]>
Sent: Mittwoch, 16. Oktober 2019 05:59
To: Schmelter, Ralf <[email protected]>;
[email protected]
Subject: Re: RFR (S) 8232168: Fix non wide char canonicalization on Windows
Hi Ralf,
This isn't a hotspot issue but a core-libs one.
The use of a hotspot-runtime test seems more opportunistic than anything
else - is it just for code coverage? I would expect to find a more
appropriate test somewhere in core-libs.
Thanks,
David
