Hi Christoph,
The changes look good.
I agree that other mentioned items (the JPLIS agent usage and moving the
canonicalize function into hotspot) could be done in separate RFEs.
thanks,
Calvin
On 10/23/19 5:57 AM, Langer, Christoph wrote:
Hi,
I've picked up Ralf's patch and cleaned it up a little bit. But apart from some
comment changes it should be the same as his original version. So, what happens is
that the windows 'canonicalize" function will only delegate to 'wcanonicalize'
from now on. Furthermore, 'canonicalizeWithPrefix' along with some auxiliary stuff
could be removed completely.
Can I please get a review for this, as I'm planning on doing further cleanup
around canonicalization.
New webrev: http://cr.openjdk.java.net/~clanger/webrevs/8232168.0/
Thanks
Christoph
-----Original Message-----
From: hotspot-runtime-dev <hotspot-runtime-dev-
boun...@openjdk.java.net> On Behalf Of Alan Bateman
Sent: Freitag, 18. Oktober 2019 12:41
To: Schmelter, Ralf <ralf.schmel...@sap.com>; David Holmes
<david.hol...@oracle.com>; hotspot-runtime-...@openjdk.java.net; Java
Core Libs <core-libs-dev@openjdk.java.net>
Subject: Re: RFR (S) 8232168: Fix non wide char canonicalization on Windows
On 16/10/2019 09:28, Schmelter, Ralf wrote:
Hi David,
the canonicalize() method is never used by java.io or any Java code.
Currently it is used by the hotspot in classloader.cpp (which I use in the test)
and in libinstrument in InvocationAdapter.c. There is no way to test it in core-
libs. One can argue if the canonicalize method is in the right file, but that
should be a separate discussion.
I plan to review this, I just haven't had time yet. You are right that
there is technical debt here, include dependency in the JPLIS agent
which crept in when java.lang.instrument was updated to support
augmenting of the boot class path.
-Alan
