Hi Alexey,
http://cr.openjdk.java.net/~asemenyuk/8223325/webrev.00/src/jdk.jpackage/share/classes/jdk/jpackage/internal/AppImageFile.java.frames.html
Line 180: man -> main
http://cr.openjdk.java.net/~asemenyuk/8223325/webrev.00/src/jdk.jpackage/share/classes/jdk/jpackage/internal/IOUtils.java.frames.html
createXml() should we force it to UTF-8? Like we did in MacPkgBundler.
http://cr.openjdk.java.net/~asemenyuk/8223325/webrev.00/src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WixTool.java.html
findWixInstallDirs() I think we used to check PATH variable as well for
Wix. In any case this needs to be fixed. We cannot assume "C:\Program
Files". This folder can be on different drive, so it is better to use
Windows API to get path to "Program Files". Also, user might install Wix
into different folder. I think it is better to file a bug and improve it
eventually.
Looks good overall.
Thanks,
Alexander
On 10/17/19 3:24 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- moved code creating WiX sources for app image from WinMsiBundler in
a separate class - WixSourcesBuilder;
- put at most one file in component in WiX sources;
- use StAX to create WiX sources;
- added IOUtils.createXml function to simplify xml creation;
- added basic javadoc to AppImageFile class;
- added support for use of icons in file associations test for better
coverage;
- fixed the bug with not excluded `.jpackage.xml` from installed app
image on Windows;
- improved test output isolation when jpackage tests are executed not
with jtreg framework;
- bugfix of MainClassTest test class;
- Alexey
[1] https://bugs.openjdk.java.net/browse/JDK-8223325
[2] http://cr.openjdk.java.net/~asemenyuk/8223325/webrev.00/
