Hi Alexey,
Looks good.
Thanks,
Alexander
On 10/22/2019 2:14 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
Additionally:
- fixes for [3], [4], [5] and [6] bugs.
- removed unused l10n strings from Windows resource files.
- replaced `throw new
ConfigException(I18N.getString("error.parameters-null"),
I18N.getString("error.parameters-null.advice"))` with
`Objects.requireNonNull(params);`. There is no point to localize
internal jpackage errors.
- add `Win64` attribute with value `yes` to all Component elements
generated for application image files. Explicit tagging of components
64bit would make sense in case somebody would like to override default
jpackage settings and make 32bit msi installers.
- added a step to call user provided .wsh after msi package is created
but before it is embedded in exe installer. Can be use to sign msi
before it get embedded in exe installer.
The patch is based on [7].
- Alexey
[1] https://bugs.openjdk.java.net/browse/JDK-8232073
[2] http://cr.openjdk.java.net/~asemenyuk/8232073/webrev.00/
[3] https://bugs.openjdk.java.net/browse/JDK-8232029
[4] https://bugs.openjdk.java.net/browse/JDK-8232646
[5] https://bugs.openjdk.java.net/browse/JDK-8136879
[6] https://bugs.openjdk.java.net/browse/JDK-8232728
[7] http://cr.openjdk.java.net/~asemenyuk/8231972/webrev.00
