On Nov 19, 2019, at 4:00 AM, Lance Andersen <lance.ander...@oracle.com> wrote: > > Seems to be a “your milage varies”. I am fine with whatever the final > decision is. However, I do believe the comment above reads better and aligns > the methods better.
FWIW, and as author of many of the lines being changed, I prefer that comment on a separate from the actual modifiers. I think the basic modifier patterns are easier to recognize quickly when comments and annotations are separate. — John P.S. And for the record, my intention of writing non-public is to ensure make it clear to maintainers that the absence of any modifier is both intentional and important (to security, in most cases). The language doesn’t give any more explicit way to document that default access is required.
