I'm going to withdraw this change. It's been very painful to describe how String::indent this works in simple terms. The fact that it took 8 precise steps to describe in the JEP is an indication that simplification needs more thought. The submitter was trying to clarify what happens when the last line was empty, but maybe his approach is not the way to go. Deferring for more thought.
-- Jim > On Jan 7, 2020, at 11:02 AM, Roger Riggs <roger.ri...@oracle.com> wrote: > > Hi Jim, > > The nature of the problem should be apparent from the summary and problem > descriptions. > > The CSR/diff does not identify the methods modified. > > The new 3rd bullet seems more like a consequence of the first 2 actions, not > an independent step. > The word 'implies' seems out of place in a specification of behavior. > I think you can drop 'this/thus implies' without loss of clarity or intent. > > Is it significant that the first change spells out \n and \r and the second > refers to 'line terminator'? > > Roger > > > On 1/7/20 7:43 AM, Jim Laskey wrote: >> Please review this CSR to clarify the javadoc details of String::indent >> (proposed by Andrew Leonard). >> >> webrev: http://cr.openjdk.java.net/~jlaskey/8230800/webrev.00/index.html >> <http://cr.openjdk.java.net/~jlaskey/8230800/webrev.00/index.html> >> csr: https://bugs.openjdk.java.net/browse/JDK-8236688 >> jbs: https://bugs.openjdk.java.net/browse/JDK-8230800 >
