On 23/03/2020 18:38, Erik Joelsson wrote:
> Looks good.

Thanks for the review, Erik.

I'm assuming that also implies it is trivial (because, copyright update
a side, it really is a 1-liner :-).

I will push to the dev tree and request a backport to jdk14u.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill

> On 2020-03-23 10:56, Andrew Dinn wrote:
>> Could I please have a review for this trivial fix to the module make
>> file which ensures that javadoc is generated for new module
>> jdk.nio.mapmode created as part of the implementation of JEP 352. The
>> original patch added the module to the BOOT_MODULES list but was not to
>> the DOCS_MODULES list.
>>
>> JIRA:   https://bugs.openjdk.java.net/browse/JDK-8241144
>> webrev: http://cr.openjdk.java.net/~adinn/8241144/webrev
>>
>> Testing:
>>
>> Built image and compiled + ran Hello World.
>>
>> Built make target docs-jdk-api-javadoc and checked module
>> jdk.nio.mapmode was included in output
>>
>> regards,
>>
>>
>> Andrew Dinn
>> -----------
>> Senior Principal Software Engineer
>> Red Hat UK Ltd
>> Registered in England and Wales under Company Registration No. 03798903
>> Directors: Michael Cunningham, Michael ("Mike") O'Neill
>>
> 

Reply via email to