Hi Mandy,
On 28/03/2020 9:46 am, Mandy Chung wrote:
On 3/27/20 4:01 PM, David Holmes wrote:
Hi Mandy,
On 28/03/2020 8:29 am, Mandy Chung wrote:
Hi Vicente,
hasNestmateAccess is about VM supports static nestmates on JDK
release >= 11.
However this is about javac --release 14 and the compiled classes may
run on JDK 14 that lambda and string concat spin classes that are not
nestmates. I have a patch with Jan's help:
http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8171335/webrev-javac-target-release-14/index.html
+ /**
+ * The VM does not support access across nested classes
(8010319).
+ * Were that ever to change, this should be removed.
+ */
+ boolean isPrivateInOtherClass() {
I'm not at all sure what this means - access across different nests?
(I'm not even sure what that means.)
This just reverts the old code that I removed.
Ah I see. This is ancient pre-nestmate code. Can we at least fix the
comment as it really doesn't make any sense
What this method is trying to determine if it accesses a private in
another class in the same nest (nested classes) that needs a synthetic
bridge method to access.
That would be a good comment to add. Something like:
If compiling for a release where the VM does not support access between
nested classes, this method indicates if a synthetic bridge method is
needed for access.
Thanks,
David
Mandy
