Hi Joe,

Can writeStartDocument() be simplified by checking "docLocator instanceof Locator2"? This way it won't need to catch CCE and issue no-arg version.

Otherwise looks good to me.

Naoto

On 3/30/20 11:02 AM, Joe Wang wrote:
Hi,

Please review a fix for the StAXResult impl. The issue was that it output comment prior to the declaration, resulting in an invalid XML document. The patch focuses on fixing this issue, but it does not cover other issues the StAXResult impl may have (e.g. JDK-8241711).

JBS: https://bugs.openjdk.java.net/browse/JDK-8238183
webrev: http://cr.openjdk.java.net/~joehw/jdk15/8238183/webrev/

Thanks,
Joe

Reply via email to