> Hi, > > The java/util/prefs/AddNodeChangeListener.java test fails once in a while in > the automated test system. Previous failures were traced to machine > configuration errors, but that does not appear to be the case this time. > > My efforts to reproduce this failure have been unsuccessful. The only useful > information I've gleaned so far from the test failure logs is that the > overall duration for running tier1 is longer than usual when the test failure > happens. > > I would like to make the following updates to the test, in hopes of learning > more if and when this test fails again: > > * fail faster, to report if it is addNode() or removeNode() that is failing > * make multiple attempts to sleep+check the NodeChangeListener. (If the test > fails after a single sleep, but passes after waiting longer, maybe we just > need to sleep for longer to account for the occasional slower tier1 test run). > * a few indentations fixes > > Thanks, > -Brent
Brent Christian has updated the pull request incrementally with one additional commit since the last revision: print counter for sleeps ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/773/files - new: https://git.openjdk.java.net/jdk/pull/773/files/5767bb3e..23eca90a Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=773&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=773&range=00-01 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/773.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/773/head:pull/773 PR: https://git.openjdk.java.net/jdk/pull/773