On Tue, 20 Oct 2020 21:49:37 GMT, Brent Christian <bchri...@openjdk.org> wrote:
> Hi, > > The java/util/prefs/AddNodeChangeListener.java test fails once in a while in > the automated test system. Previous failures were traced to machine > configuration errors, but that does not appear to be the case this time. > > My efforts to reproduce this failure have been unsuccessful. The only useful > information I've gleaned so far from the test failure logs is that the > overall duration for running tier1 is longer than usual when the test failure > happens. > > I would like to make the following updates to the test, in hopes of learning > more if and when this test fails again: > > * fail faster, to report if it is addNode() or removeNode() that is failing > * make multiple attempts to sleep+check the NodeChangeListener. (If the test > fails after a single sleep, but passes after waiting longer, maybe we just > need to sleep for longer to account for the occasional slower tier1 test run). > * a few indentations fixes > > Thanks, > -Brent This pull request has now been integrated. Changeset: 8afdcaee Author: Brent Christian <bchri...@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/8afdcaee Stats: 56 lines in 1 file changed: 37 ins; 3 del; 16 mod 8255031: Update java/util/prefs/AddNodeChangeListener.java to report more failure info Reviewed-by: bpb ------------- PR: https://git.openjdk.java.net/jdk/pull/773
