On Thu, 17 Dec 2020 14:01:14 GMT, Andrey Turbanov 
<github.com+741251+turban...@openjdk.org> wrote:

>> 8258422: Cleanup unnecessary null comparison before instanceof check in 
>> java.base
>
> Andrey Turbanov has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8258422: Cleanup unnecessary null comparison before instanceof check in 
> java.base

src/java.base/share/classes/jdk/internal/misc/Signal.java line 101:

> 99:      * @return whether two <code>Signal</code> objects are equal.
> 100:      */
> 101:     public boolean equals(Object oth) {

I'd  suggest to replace `oth` with `obj` and fix the `@param` clause in the 
method javadoc.

-------------

PR: https://git.openjdk.java.net/jdk/pull/20

Reply via email to