On Thu, 25 Feb 2021 17:23:11 GMT, Paul Sandoz <psan...@openjdk.org> wrote:
>> Jie Fu has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> The numerator should be 8 (byte)
>
> src/hotspot/share/prims/vectorSupport.cpp line 368:
>
>> 366: if (java_lang_Class::is_primitive(mirror)) {
>> 367: BasicType bt = java_lang_Class::primitive_type(mirror);
>> 368: int min_lane_count = 64 / type2aelembytes(bt);
>
> I am uncertain of the units here. Is the numerator in bits and the
> denominator in bytes?
Thanks Paul for your review.
Oops, the numerator should be 8 (bytes).
Updated.
Testing of jdk/incubator/vector (MaxVector=default/8/4 or without C2) is still
fine.
Thanks.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2722
