On Fri, 26 Feb 2021 00:30:45 GMT, Paul Sandoz <[email protected]> wrote:

> Thanks, was the test `VectorShapeInitTest` passing prior to the fix of the 
> numerator?
Yes. It also passed with min_lane_count = 64 / type2aelembytes(bt).

> Perhaps we should be testing more directly on 
> `VectorShape.S_Max_BIT.vectorBitSize()` and `VectorShape.preferredShape` ?
Ok.
But it that case, I'd like to just re-use 
jdk/incubator/vector/PreferredSpeciesTest.java.

> Also, perhaps we can run with C2 disabled, with `-XX:TieredStopAtLevel=3` ?
Fine.
Although this bug wouldn't be triggered with -XX:TieredStopAtLevel=x, it can 
help test  with C1.

Patch had been updated.
Any comments?
Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2722

Reply via email to