On Mar 27, 2021, at 12:05 PM, Alan Bateman
<al...@openjdk.java.net<mailto:al...@openjdk.java.net>> wrote:
On Fri, 26 Feb 2021 17:03:11 GMT, Jaikiran Pai
<j...@openjdk.org<mailto:j...@openjdk.org>> wrote:
Can I please get a review for this patch which proposes to implement the
enhancement request noted in https://bugs.openjdk.java.net/browse/JDK-8173970?
The commit in this PR introduces the `-o` and `--output-dir` option to the
`jar` command. The option takes a path to a destination directory as a value
and extracts the contents of the jar into that directory. This is an optional
option and the changes in the commit continue to maintain backward
compatibility where the jar is extracted into current directory, if no `-o` or
`--output-dir` option has been specified.
As far as I know, there hasn't been any discussion on what the name of this new
option should be. I was initially thinking of using `-d` but that is currently
used by the `jar` command for a different purpose. So I decided to use `-o` and
`--output-dir`. This is of course open for change depending on any suggestions
in this PR.
The commit in this PR also updates the `jar.properties` file which contains the
English version of the jar command's `--help` output. However, no changes have
been done to the internationalization files corresponding to this one (for
example: `jar_de.properties`), because I don't know what process needs to be
followed to have those files updated (if at all they need to be updated).
The commit also includes a jtreg testcase which verifies the usage of this new
option.
I think the summary is that we've converged on -C/--dir. We might have to tweak
the usage message for -C so that it starts with the existing "Change to the
specified directory ..." rather than changing it to start with the extract case.
Are you, or Lance, going to create the CSR for this?
I have not had a chance to go through the latest update from Jaikiran or his
revised PR yet.
Yes, once we flush everything out, I will work with Jaikiran on the CSR and
determine which of us will create the CSR. On the todo list for next week.
Best
Lance
-------------
PR: https://git.openjdk.java.net/jdk/pull/2752
[cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC@home]
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com<mailto:lance.ander...@oracle.com>
