On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy <da...@openjdk.org> wrote:
> 8244146: javac changes for JEP 306 Overall, looks good other than the various minor issues called out. I wonder if the tests would have turned out to be a good bit simpler if we simply checked diagnostics against a golden file and skipped the toolbox approach. Is there a strong benefit to using the toolbox approach for the present need ?? Also, another model for tests could have been test/langtools/tools/javac//7166455/CheckACC_STRICTFlagOnclinitTest.java rather than using an annotation processor. (Not asking for a change, just an academic question/observation) ------------- PR: https://git.openjdk.java.net/jdk/pull/3831
