On Tue, 4 May 2021 11:47:25 GMT, Thomas Schatzl <tscha...@openjdk.org> wrote:
>> Kim Barrett has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - more comment improvements >> - improve naming and comments around injected String flags >> - fix some typos in comments > > src/hotspot/share/classfile/javaClasses.hpp line 171: > >> 169: static inline bool is_latin1(oop java_string); >> 170: static inline bool no_deduplication(oop java_string); >> 171: static inline bool deduplication_requested(oop java_string); > > Having a verb at the beginning like `is_deduplication_requested` sounds > better. "is_deduplication_requested" suggests there is currently a request, but this flag remains true even after the request is processed. ------------- PR: https://git.openjdk.java.net/jdk/pull/3662
