On Tue, 4 May 2021 11:46:21 GMT, Thomas Schatzl <tscha...@openjdk.org> wrote:
>> Kim Barrett has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - more comment improvements >> - improve naming and comments around injected String flags >> - fix some typos in comments > > src/hotspot/share/classfile/javaClasses.hpp line 170: > >> 168: static inline bool hash_is_set(oop string); >> 169: static inline bool is_latin1(oop java_string); >> 170: static inline bool no_deduplication(oop java_string); > > That identifier is missing a verb to read better, but I do not have a good > idea. Maybe it would be easier to use the negation of "no_deduplication", > something like "may_deduplicate"? > Feel free to ignore. "may_deduplicate" would require internally flipping the sense, to account for the initial value being false because of zero-initialization. I've changed it to "deduplication_forbidden"; hopefully that helps. ------------- PR: https://git.openjdk.java.net/jdk/pull/3662
