On Fri, 7 May 2021 16:50:15 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
>> - Replaced direct TKit.run() calls with Test annotation.
>> - Increased timeout for SigningPackageTest from default to 360 due to
>> timeout. This is regression from JDK-8248904 due to changes done in signing
>> and --remove-signature adds additional time since it is run per file.
>> - Fixed issue with jtreg.SkippedException which caused test to fail instead
>> of being skipped, since it was wrapped in ExceptionBox.
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Functional.java line 161:
>
>> 159: }
>> 160:
>> 161: if
>> (throwable.getClass().getName().equals("jtreg.SkippedException")) {
>
> Would it make sense to have check: `if (throwable instanceof Runnable)`?
Not sure. I do not think it will work. SkippedException extends
RuntimeException, so not sure why we need to check it with Runnable.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3911
