On Fri, 7 May 2021 23:07:02 GMT, Alexander Matveev <almat...@openjdk.org> wrote:

>> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Functional.java line 161:
>> 
>>> 159:         }
>>> 160: 
>>> 161:         if 
>>> (throwable.getClass().getName().equals("jtreg.SkippedException")) {
>> 
>> Would it make sense to have check: `if (throwable instanceof Runnable)`?
>
> Not sure. I do not think it will work. SkippedException extends 
> RuntimeException, so not sure why we need to check it with Runnable.

My point is that if the exception is Runnable, there is no need to wrap it in 
ExceptionBox instance.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3911

Reply via email to