Hi Brian,
Thanks for looking at this.
The JDK no longer creates unsafe anon classes. So, those tests could
only find an unsafe anonymous class if they explicitly created one. In
which case, the tests would need to call Unsafe.defineAnonymousClass().
And, hopefully, those tests have been handled in this webrev.
If there are dead tests then they probably died when the JDK stopped
creating unsafe anon classes. Note that none of them showed up as
failures during regression testing.
Harold
On 5/11/2021 9:20 AM, Brian Goetz wrote:
There may be some JDK code that checks for anon classes by comparing the name
to see if it contains a slash, especially tests, but which don’t say
“anonymous”. Did you do a search for these idioms too, which are now dead
tests?
Sent from my iPad
On May 11, 2021, at 8:59 AM, Harold Seigel <[email protected]> wrote:
Please review this large change to remove Unsafe::defineAnonymousClass(). The
change removes dAC relevant code and changes a lot of tests. Many of the
changed tests need renaming. I hope to do this in a follow up RFE. Some of
the tests were modified to use hidden classes, others were deleted because
either similar hidden classes tests already exist or they tested dAC specific
functionality, such as host classes.
This change was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and
Mach5 tiers 3-7 on Linux x64.
Thanks, Harold
-------------
Commit messages:
- 8243287: Removal of Unsafe::defineAnonymousClass
Changes: https://git.openjdk.java.net/jdk/pull/3974/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3974&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8243287
Stats: 3516 lines in 116 files changed: 69 ins; 3181 del; 266 mod
Patch: https://git.openjdk.java.net/jdk/pull/3974.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/3974/head:pull/3974
PR: https://git.openjdk.java.net/jdk/pull/3974
