On Tue, 11 May 2021 14:13:49 GMT, Harold Seigel <hsei...@openjdk.org> wrote:
>> Please review this large change to remove Unsafe::defineAnonymousClass(). >> The change removes dAC relevant code and changes a lot of tests. Many of >> the changed tests need renaming. I hope to do this in a follow up RFE. >> Some of the tests were modified to use hidden classes, others were deleted >> because either similar hidden classes tests already exist or they tested dAC >> specific functionality, such as host classes. >> >> This change was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows, >> and Mach5 tiers 3-7 on Linux x64. >> >> Thanks, Harold > > Harold Seigel has updated the pull request incrementally with one additional > commit since the last revision: > > fix GetModuleTest.java The CDS VM and test changes look OK to me. src/hotspot/share/oops/instanceMirrorKlass.inline.hpp line 65: > 63: // so when handling the java mirror for the class we need to make > sure its class > 64: // loader data is claimed, this is done by calling do_cld > explicitly. > 65: // For non-string hidden classes the call to do_cld is made when > the class Typo: non-strong ------------- Marked as reviewed by iklam (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3974
