On Wed, 12 May 2021 16:10:24 GMT, Harold Seigel <[email protected]> wrote:
>> Please review this large change to remove Unsafe::defineAnonymousClass().
>> The change removes dAC relevant code and changes a lot of tests. Many of
>> the changed tests need renaming. I hope to do this in a follow up RFE.
>> Some of the tests were modified to use hidden classes, others were deleted
>> because either similar hidden classes tests already exist or they tested dAC
>> specific functionality, such as host classes.
>>
>> This change was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows,
>> and Mach5 tiers 3-7 on Linux x64.
>>
>> Thanks, Harold
>
> Harold Seigel has updated the pull request incrementally with one additional
> commit since the last revision:
>
> test changes and small fixes
Overall looks good to me.
src/hotspot/share/classfile/classLoaderData.cpp line 299:
> 297: }
> 298:
> 299: // Weak hidden classes have their own ClassLoaderData that is marked to
> keep alive
`s/Weak/Non-strong/`
test/hotspot/jtreg/runtime/HiddenClasses/StressHiddenClasses.java line 39:
> 37: import jdk.test.lib.compiler.InMemoryJavaCompiler;
> 38:
> 39: public class StressHiddenClasses {
Since `StressClassLoadingTest` is revised to test hidden class, this test is a
subset of it.
I think this can be removed as JDK-8265694 suggests.
-------------
Marked as reviewed by mchung (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3974
