On Wed, 19 May 2021 10:00:04 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:

>> Jaroslav Bachorik has updated the pull request with a new target base due to 
>> a merge or a rebase. The pull request now contains 10 commits:
>> 
>>  - Small fixes
>>  - Remove trailing spaces
>>  - Doh
>>  - Report container type and register events conditionally
>>  - Remove unused test files
>>  - Initial test support for JFR container events
>>  - Update the JFR control files
>>  - Split off the CPU throttling metrics
>>  - Formatting spaces
>>  - 8203359: Container level resources events
>
> src/jdk.jfr/share/classes/jdk/jfr/events/ContainerMemoryUsageEvent.java line 
> 48:
> 
>> 46:     @Description("(attempts per second * 1000), if enabled, that the 
>> operating system tries to satisfy a memory request for any " +
>> 47:                  "process in the current container when no free memory 
>> is readily available.")
>> 48:     public double memoryPressure;
> 
> Should this `memoryPressure` field go from `ContainerMemoryUsageEvent` class? 
> It's not set anywhere is it? would be cgroup v1 only api so I'm not sure it 
> should be there for a generic event like this.

Yes. Removing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3126

Reply via email to