> GetApplicationHomeFromDll() fails if the path to libjli.so contains "bin" 
> component (/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so). TruncatePath() 
> looks for "/bin/" first in "/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so" 
> string and then it looks for "/lib/". But this is wrong order as it should 
> look for "/lib/" first. I.e. TruncatePath() should look for "/bin/" and then 
> for "/lib/" if called from GetApplicationHome() and for "/lib/" first and 
> then for "/bin/" if called from GetApplicationHomeFromDll().

Alexey Semenyuk has updated the pull request with a new target base due to a 
merge or a rebase. The incremental webrev excludes the unrelated changes 
brought in by the merge/rebase. The pull request contains four additional 
commits since the last revision:

 - Merge branch 'master' into JDK-8268974
 - Test added
 - - Comments updated.
   - pathisso -> pathisdll.
 - 8268974: jpackage fails to handle --dest option containing "bin" folder

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4534/files
  - new: https://git.openjdk.java.net/jdk/pull/4534/files/19ac6551..7934b977

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4534&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4534&range=02-03

  Stats: 88952 lines in 1561 files changed: 47547 ins; 34348 del; 7057 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4534.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4534/head:pull/4534

PR: https://git.openjdk.java.net/jdk/pull/4534

Reply via email to