On Tue, 31 Aug 2021 01:12:40 GMT, David Holmes <[email protected]> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revised to use native /bin/sleep program on Unix* (non-Windows).
>> For Windows, a native "BasicSleep" program is used.
>
> test/jdk/java/lang/ProcessBuilder/Basic.java line 2646:
>
>> 2644: if (exePath.toFile().canExecute()) {
>> 2645: return exePath;
>> 2646: }
>
> Not sure why this is so elaborate when elsewhere in the test we just assume
> `/usr/bin/env` exists?
True enough, will simplify. At one point, I was going to name the BasicSleep
just "sleep" and put the native path at the end of a search list. Some other
executables are not reliably in the same directories in all Unix versions.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5239